Repository navigation
Increase the browser protocol timeout - #21995
Merged
timvandermeij merged 1 commit intoSep 22, 2026
Merged
Conversation
Use `browserTimeout` for protocol calls so Firefox's `session.new` command gets more than 22.5 seconds to complete. Give dedicated tests time for the protocol and close timeouts, and use `killBrowser` for cleanup. Fixes mozilla#21978.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21995 +/- ##
==========================================
+ Coverage 90.28% 90.36% +0.07%
==========================================
Files 269 269
Lines 67543 67271 -272
==========================================
- Hits 60984 60789 -195
+ Misses 6559 6482 -77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Sep 22, 2026
Collaborator
|
Thank you for improving this logic! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
browserTimeoutfor protocol calls so Firefox'ssession.newcommand gets more than 22.5 seconds to complete.Give dedicated tests time for the protocol and close timeouts, and use
killBrowserfor cleanup.Fixes #21978.