Skip to content

Enable the unicorn/prefer-combined-guards linting rule - #21990

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
timvandermeij:eslint-rule
Sep 20, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
timvandermeij:eslint-rule

Conversation

@timvandermeij

Copy link
Copy Markdown
Collaborator

This reduces the number of branches in the code, and thereby the number of lines of code, which ever so slightly improves readability.

@codecov-commenter

codecov-commenter commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.37%. Comparing base (ccd820e) to head (accd78d).

Files with missing lines Patch % Lines
src/core/catalog.js 0.00% 1 Missing ⚠️
src/core/postscript/wasm_compiler.js 88.88% 1 Missing ⚠️
web/app.js 0.00% 1 Missing ⚠️
web/pdf_history.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21990      +/-   ##
==========================================
+ Coverage   90.34%   90.37%   +0.02%     
==========================================
  Files         269      269              
  Lines       67337    67271      -66     
==========================================
- Hits        60836    60793      -43     
+ Misses       6501     6478      -23     
Flag Coverage Δ
browsertest 66.20% <48.38%> (+<0.01%) ⬆️
fonttest 8.95% <100.00%> (+<0.01%) ⬆️
integrationtest 69.42% <57.57%> (+0.03%) ⬆️
unittest 59.52% <70.96%> (+0.01%) ⬆️
unittestcli 58.06% <67.74%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for accd78d (run, references from mozilla/pdf.js.refs@41924e1198).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1380 12m 2s 0 281 0 0 view differences
Windows ✅ 1380 13m 32s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Sep 20, 2026

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

Comment thread src/core/image_utils.js Outdated
This reduces the number of branches in the code, and thereby the number
of lines of code, which ever so slightly improves readability.
@timvandermeij

Copy link
Copy Markdown
Collaborator Author

/botio browsertest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6a36643bd233e33/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_browsertest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0075dc39307ac0d/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/0075dc39307ac0d/output.txt

Total script time: 18.91 mins

  • Regression tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/6a36643bd233e33/output.txt

Total script time: 24.11 mins

  • Regression tests: Passed

@timvandermeij
timvandermeij merged commit b7338b8 into mozilla:master Sep 20, 2026
23 checks passed
@timvandermeij
timvandermeij deleted the eslint-rule branch September 20, 2026 13:22
@timvandermeij
timvandermeij removed the request for review from calixteman September 20, 2026 13:22

This branch was successfully deployed

1 active deployment
sync_pdfs — accd78d0 Deployed Sep 20, 2026 by timvandermeij via request #119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants