Repository navigation
Give copied annotations distinct references - #21707
Merged
timvandermeij merged 1 commit intoAug 4, 2026
Merged
Conversation
When a viewer page was copied, each copy got its own annotationStorage entry, but newAnnotationsByPage was keyed only by source page. As a result, every output copy received all entries and reused their memoized references. Tag each entry with its rank among output copies of the same source page. The display and worker compute this rank independently; inserted documents preserve the order of copies. Keep unextracted entries at rank -1 so shared stamp bitmaps remain available without being written. Without ranks, new annotations are applied only to the first copy.
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
calixteman
temporarily deployed
to
code-coverage
August 4, 2026 15:50 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21707 +/- ##
==========================================
+ Coverage 90.04% 90.05% +0.01%
==========================================
Files 264 264
Lines 66894 66933 +39
==========================================
+ Hits 60232 60275 +43
+ Misses 6662 6658 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Aug 4, 2026
Collaborator
|
Looks good to me; thanks! |
This was referenced Sep 1, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a viewer page was copied, each copy got its own annotationStorage entry, but newAnnotationsByPage was keyed only by source page. As a result, every output copy received all entries and reused their memoized references.
Tag each entry with its rank among output copies of the same source page. The display and worker compute this rank independently; inserted documents preserve the order of copies. Keep unextracted entries at rank -1 so shared stamp bitmaps remain available without being written. Without ranks, new annotations are applied only to the first copy.