Repository navigation
Add a go to first/last menu-item helper method in the Menu class - #21690
Merged
Merged
Conversation
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:11 — with
GitHub Actions
Error
Menu classMenu class
Snuffleupagus
force-pushed
the
Menu-#goToInitial
branch
from
August 2, 2026 13:12
83e4800 to
9604579
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Failure
Snuffleupagus
had a problem deploying
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Failure
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 2, 2026 13:12 — with
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21690 +/- ##
=======================================
Coverage 90.01% 90.02%
=======================================
Files 264 264
Lines 66893 66894 +1
=======================================
+ Hits 60214 60219 +5
+ Misses 6679 6675 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
calixteman
reviewed
Aug 3, 2026
calixteman
reviewed
Aug 3, 2026
calixteman
approved these changes
Aug 3, 2026
calixteman
left a comment
Contributor
There was a problem hiding this comment.
LGTM. It'd be nice to have an integration test too, but if you don't have time to do one, please tell me and I'll do it myself in a follow-up.
Thank you.
This fixes a bug when using the <kbd>Home</kbd> and <kbd>End</kbd> keyboard shortcuts to navigate through a `Menu` instance. These two buttons didn't update the `#lastIndex` field, which means that e.g. a following <kbd>ArrowDown</kbd> or <kbd>ArrowUp</kbd> press could make focus "jump" to an unexpected menu-item. Also, the helper method reduces a little bit of code duplication in the event handlers.
Snuffleupagus
force-pushed
the
Menu-#goToInitial
branch
from
August 3, 2026 20:26
9604579 to
fc610d3
Compare
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Snuffleupagus
temporarily deployed
to
code-coverage
August 3, 2026 20:26 — with
GitHub Actions
Inactive
Collaborator
Author
It would be great if you could do that in a follow-up, thank you! |
calixteman
added a commit
that referenced
this pull request
Aug 4, 2026
Follow-up to PR #21690: these tests check that pressing Home/End correctly updates the last focused menu-item index, so that a following ArrowUp/ArrowDown press doesn't move focus to an unexpected menu-item.
This was referenced Sep 1, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when using the Home and End keyboard shortcuts to navigate through a
Menuinstance. These two buttons didn't update the#lastIndexfield, which means that e.g. a following ArrowDown or ArrowUp press could make focus "jump" to an unexpected menu-item.Also, the helper method reduces a little bit of code duplication in the event handlers.