Skip to content

Add text extractor as an external service - #20406

Merged
calixteman merged 2 commits into
mozilla:masterfrom
gregtatum:text-extractor
Oct 30, 2025
Merged

calixteman merged 2 commits into
mozilla:masterfrom
gregtatum:text-extractor

Conversation

@gregtatum

Copy link
Copy Markdown
Member

This is the upstream patch for adding PDF support to the PageExtractor component. I couldn't figure out how to add a test here, as I didn't see good prior art, but I do have a test in the Firefox side of the work.

https://bugzilla.mozilla.org/show_bug.cgi?id=1994839

@gregtatum
gregtatum requested a review from calixteman October 29, 2025 18:12
Comment thread web/app.js Outdated
Comment thread web/pdf_text_extractor.js Outdated
Comment thread web/pdf_text_extractor.js Outdated
Comment thread web/pdf_text_extractor.js
@gregtatum
gregtatum requested a review from calixteman October 30, 2025 14:55
@calixteman

Copy link
Copy Markdown
Contributor

/botio integrationtest

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/990819ae6d9e476/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7754557bcf6be51/output.txt

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7754557bcf6be51/output.txt

Total script time: 19.65 mins

  • Integration Tests: Passed

@moz-tools-bot

Copy link
Copy Markdown
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/990819ae6d9e476/output.txt

Total script time: 45.37 mins

  • Integration Tests: Passed

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@calixteman
calixteman merged commit 27bb5fb into mozilla:master Oct 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants