Repository navigation
Bump nodeenv to 1.11.1 so the lint task runs again - #7355
Merged
Merged
Conversation
nodeenv 1.10.0 chokes on the new v27.0.0-alpha entry in the Node.js release index while picking a version for the prettier hook, so every lint task in CI dies before pre-commit even starts. 1.11.1 skips pre-releases. Fixes mozilla#7353
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request. Check if the Files changed in this pull request are included in default exclusions.
marco-c
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7353
What: bumps
nodeenv1.10.0 -> 1.11.1 inuv.lock. Nothing else changes.Why: nodejs.org's release index now lists
v27.0.0-alpha.0.0.0first. nodeenv 1.10.0 tries toint()that when it picks a Node version for the prettier hook and dies withinvalid literal for int() with base 10: '0-alpha', so every lint task fails before pre-commit runs anything. nodeenv 1.11.1 (released yesterday) skips pre-releases: ekalinin/nodeenv#454.How I tested: ran
python -m nodeenv --prebuilt <dir>with both versions. 1.10.0 reproduces the exact traceback from the CI log, 1.11.1 installs Node 26.13.0 fine. The lock was regenerated withuv lock --upgrade-package nodeenvon uv 0.13.6 so the lock revision stays the same.