Skip to content

[docs] Migrate Experience_API_(xAPI) - #560

Merged
paulholden merged 1 commit into
moodle:mainfrom
sarjona:xapi
Mar 20, 2023
Merged

[docs] Migrate Experience_API_(xAPI)#560
paulholden merged 1 commit into
moodle:mainfrom
sarjona:xapi

Conversation

@sarjona

@sarjona sarjona commented Feb 24, 2023

Copy link
Copy Markdown
Member

@netlify

netlify Bot commented Feb 24, 2023

Copy link
Copy Markdown

Deploy Preview for moodledevdocs ready!

Name Link
🔨 Latest commit ffdda8c
🔍 Latest deploy log https://app.netlify.com/sites/moodledevdocs/deploys/64183f392902c600070e56af
😎 Deploy Preview https://deploy-preview-560--moodledevdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarjona sarjona linked an issue Feb 24, 2023 that may be closed by this pull request
@github-actions

github-actions Bot commented Feb 24, 2023

Copy link
Copy Markdown
Contributor

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 64 🟠 87 🟢 100 🟢 90 🟢 100 Report
/docs/apis/commonfiles 🔴 48 🟠 85 🟢 100 🟢 100 🟢 100 Report
/general/development/gettingstarted 🟠 55 🟠 87 🟢 100 🟢 90 🟢 100 Report
/general/releases 🔴 49 🟠 87 🟢 100 🟢 100 🟢 100 Report

@paulholden paulholden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First time I actually read what the x in xAPI actually stood for

There's a few grammatical errors that would be worth addressing here I think, thanks Sara!

Comment thread docs/apis/subsystems/xapi/index.md Outdated
Comment thread docs/apis/subsystems/xapi/index.md Outdated
Comment thread docs/apis/subsystems/xapi/index.md
Comment thread docs/apis/subsystems/xapi/index.md Outdated
Comment thread docs/apis/subsystems/xapi/index.md Outdated
Comment thread docs/apis/subsystems/xapi/index.md Outdated
Comment thread docs/apis/subsystems/xapi/index.md Outdated
@sarjona

sarjona commented Mar 20, 2023

Copy link
Copy Markdown
Member Author

Hi @paulholden!
Thanks a lot for reviewing this patch and raising all these points. I've addressed them so, hopefully, it should be now ready to land :-)

@paulholden paulholden left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

@paulholden
paulholden added this pull request to the merge queue Mar 20, 2023
@paulholden
paulholden merged commit 4ab94f0 into moodle:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

https://docs.moodle.org/dev/Experience_API_(xAPI)

2 participants