[Docs] Migrate Tag API - #274
Merged
Merged
Conversation
✅ Deploy Preview for moodledevdocs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
45 tasks
andrewnicols
previously requested changes
Jul 5, 2022
Chocolate-lightning
force-pushed
the
tagapi
branch
from
July 5, 2022 14:00
0cc8b20 to
0d7cd63
Compare
Contributor
⚡️ Lighthouse report for the deploy preview of this PR
|
Member
|
@Chocolate-lightning it would be great if you could find some time to address the points raised by Andrew!! Thanks in advance for your help!!! :-* |
Chocolate-lightning
force-pushed
the
tagapi
branch
from
October 21, 2022 03:58
6d499e1 to
abac2e2
Compare
Collaborator
Author
|
Pretty sure I have addressed the items but it has been a while so my memory is foggy. Would be nice to get some fresh eyes on the current iteration. Many thanks. |
sarjona
requested changes
Oct 25, 2022
sarjona
left a comment
sarjona
left a comment
Member
There was a problem hiding this comment.
HI @Chocolate-lightning!
Thanks for reviewing the points raised by Andrew! As you'll see, we're almost there and only a few minor improvements/changes have been requested to integrate it!
Chocolate-lightning
force-pushed
the
tagapi
branch
2 times, most recently
from
October 26, 2022 03:22
78ae052 to
038ae96
Compare
Chocolate-lightning
requested review from
sarjona
and removed request for
andrewnicols
October 26, 2022 03:30
Chocolate-lightning
force-pushed
the
tagapi
branch
from
October 26, 2022 08:07
038ae96 to
a266263
Compare
sarjona
approved these changes
Oct 26, 2022
sarjona
left a comment
sarjona
left a comment
Member
There was a problem hiding this comment.
Thanks Matt! The patch looks great and I'm more than happy to approve and merge it! Yupiiiii! :-)
Member
|
@Chocolate-lightning whenever you can, it would be great if you could rebase your branch ;-) |
Chocolate-lightning
force-pushed
the
tagapi
branch
from
October 26, 2022 23:31
a266263 to
d8e1a68
Compare
sarjona
dismissed
andrewnicols’s stale review
November 29, 2022 09:47
This changes were reviewed in the past :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.