refactor: convert focus state to a signal (@miodec) - #7380
Merged
Conversation
github-actions
Bot
added
the
waiting for review
fehmer
previously approved these changes
Jan 16, 2026
github-actions
Bot
removed
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the focus state management by converting from a local module-level variable to a centralized SolidJS signal. This aligns with the project's ongoing effort to migrate state management to reactive signals.
Changes:
- Converted local
statevariable to a SolidJS signal (getFocus/setFocus) - Added focus signal to
signals/core.tsfor centralized state management - Updated all internal references to use the new signal getters/setters
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/ts/test/focus.ts | Replaced local state variable with signal calls; updated three locations to use getFocus() and setFocus() |
| frontend/src/ts/signals/core.ts | Added new focus signal export following existing signal patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.