Repository navigation
JSON без валидных пар переходов статусов — MODE_INVALID - #788
Open
Ibochkarev wants to merge 1 commit into
Open
Ibochkarev wants to merge 1 commit into
Ibochkarev wants to merge 1 commit into
Conversation
Align JSON and array resolve paths with CSV: no valid pairs means MODE_INVALID, not an empty allow-list that denies every transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
OrderStatusTransitionPolicy::resolve()для CSV уже возвращалMODE_INVALID, если после разбора не осталось ни одной валидной пары. JSON-ветка (и путьis_array) отдавалиMODE_ONс пустыми рёбрами: белый список, в котором запрещено всё. Сообщение уводило в «переход не разрешён» вместо «настройка неверна». Теперь JSON/[]/[[0,0]]и аналоги симметричны CSV.Тип изменений
Связанные Issues
Closes #786
Как это было протестировано?
composer ci:php/composer test,npm run lint:ci,composer stan/ GitHub Actions CI)Конфигурация тестирования:
Скриншоты (если применимо)
Чеклист
composer stan/ CI jobPHPStan)npm run lint:ciдля Vue)Дополнительные заметки
[]трактуется какMODE_INVALID, не какMODE_OFF: выключить проверку по-прежнему можно пустой строкой настройки. См. обсуждение в #786.