Skip to content

input-groups are using wrong class and markup #91

Open

Description

@cadu-leite

the actual makup at app/forms/input-groups.hbs is

    <div class="input-group">
        <span class="input-group-addon">$</span>
        <input type="text" class="form-control" placeholder="Some text here">
        <span class="input-group-addon">.00</span>  <!- input-group-addon class is no more -->
    </div>

when I believe it should be

    <div class="input-group">
        <div class="input-group-prepend">  <!-  for prepend - need a outer div.input-group-XXXX -->
            <span class="input-group-text">@</span> <!-  input-group-text is the new class -->
        </div>
        <input type="text" class="form-control" placeholder="Some text here">
    </div>

    <div class="input-group">
        <input type="text" class="form-control" placeholder="Input with append text">
        <div class="input-group-append">  <!-  for append -->
            <span class="input-group-text">.00</span>
        </div>
    </div>

this is not the look&feel it should have

screen shot 2018-03-12 at 16 52 06

Activity

  1. changed the title [-]input groups wrong class and markup[/-] [+]input-groups are using wrong class and markup[/+] on Mar 12, 2018
  2. modularcoder commented on Mar 13, 2018

    @modularcoder
    Member

    @cadu-leite thanks a lot!
    Will try to fix this as soon as possible.
    Or can you make a pull request for this fix?

    Thanks!

  3. cadu-leite commented on Mar 13, 2018

    @cadu-leite
    Author

    sure ... Glad to help
    ... may I'll take some time ... finishing a demo @ my job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions