Repository navigation
Conversation
`modl run` skips sub-jobs whose work is already on disk, but the completion key was only (prompt, seed, model). Re-running the same prompt/seed at a different guidance or step count matched the old key, so the run skipped generation and handed back the STALE image while printing `✓ complete` and exiting 0. Any guidance/steps sweep was silently corrupted — the same failure class as the silently-dropped configs (#145): it looks accepted, nothing errors, and the run is quietly not what was asked for. The completion key is now (prompt, seed, base_model, steps, guidance). The generate spec is built before the skip check so the resolved steps/guidance (after fast/lightning/default precedence) go into the key, then reused for execution — no double build. Guidance is an f32 (neither Eq nor Hash), so it is quantized to an integer (×1000, rounded) that round-trips stably through the YAML sidecar. Edit steps have no skip path, so no change there. Tests: completion_index_keys_on_steps_and_guidance (distinct settings are distinct keys; unseen settings miss) and quantize_guidance_is_stable_and_distinct. Verified end-to-end with SD-1.5: identical guidance skips, changed guidance regenerates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
modl runskips sub-jobs whose output is already on disk, but the completion key was only(prompt, seed, model). Re-running the same prompt/seed at a different guidance or step count matched the old key, so the run skipped generation and handed back the stale image — while printing✓ completeand exiting 0.Any guidance/steps sweep was silently corrupted. Same failure class as the silently-dropped configs in #145: it looks accepted, nothing errors, and the run is quietly not what was asked for.
Found the hard way: a guidance 3.0 → 2.5 re-run returned the 3.0 images and reported success. Only caught by diffing the output-image count.
Fix
(prompt, seed, base_model, steps, guidance).fast/lightning/default precedence) go into the key — then reused for execution, no double build.guidanceisf32(neitherEqnorHash), so it is quantized to an integer (×1000, rounded) viaquantize_guidance, stable across the YAML-sidecar round-trip.Tests
completion_index_keys_on_steps_and_guidance— distinct settings → distinct keys; unseen settings miss.quantize_guidance_is_stable_and_distinct.🤖 Generated with Claude Code