docs(architecture): correct resolution.md after the edge-set unification - #322
Merged
Merged
Conversation
PR #320 deleted `WiringPlan.dependencies` but left resolution.md describing it, and landed the "One edge set" note un-indented mid-list, terminating the numbered list so the absent-parameter item restarted at 1. Name `edges` where the deleted field was named, and re-place the note after the list ends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #320, which deleted
WiringPlan.dependenciesbut leftarchitecture/resolution.mdstill documenting it.Two defects:
Stale field. The Step 4 trailing paragraph still read "plus the
dependenciesview and theunwireablerecords are memoized on theCacheItem…get_dependenciesreadsdependencies". That field no longer exists;get_dependenciesreturns the derivedplan.edges.Broken list. The "One edge set" blockquote was inserted un-indented between items 2 and 3 of the numbered list, terminating it — so the absent-parameter item restarted at 1 and its sub-blockquote floated free.
The note is re-placed after the list ends, and now also records why a
kwargs=-only cycle is unconstructible (a provider cannot be passed to its ownkwargs=), which is what makesfind_dep_provider's owner-exclusion asymmetry correct.Docs only.
just lint-ciclean.🤖 Generated with Claude Code