docs(planning): record closures for architecture-review candidates 3 and 5 - #316
Merged
Merged
Conversation
Candidate 3 (make SignatureItem opaque) is superseded by the graph-traversal unification (#308); Candidate 5 (bless a provider-introspection seam for grpc) is declined as a hypothetical seam (grpc is the sole consumer). Both record load-bearing reasons so a future architecture review does not re-suggest them. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Records the two closed outcomes of the 2026-07-13 architecture review as decision records, so a future review doesn't re-suggest them. The three shipped candidates (1 the integration kit, 2
CacheItem.get_or_create#314, 4 the override short-circuit fold #315) already live in git history + change bundles; the closed ones had no durable home.Records added
2026-07-14-signatureitem-opacity-superseded.md— Candidate 3 (makeSignatureItemopaque) is superseded by Unify provider-graph traversal behind a DependencyGraph module #308: the graph-traversal unification already extracted its two behaviours aswiring.pyfunctions (find_dep_provider= "which provider backs this",absent_disposition= "what if absent"), and placed them as free functions rather than methods-on-SignatureItem— deliberately better, since it keeps the parse-tree record from importing the resolution machinery. Residual field-reads infactory.pyare thin and non-duplicated.2026-07-14-grpc-registry-introspection-declined.md— Candidate 5 (a blessedis_registeredseam for grpc's idempotent registration) is declined as a hypothetical seam: grpc is the sole consumer (grep across all adapters confirms), it uses the publicproviders_registry.find_provider, andadd_providers' strictness is a deliberate feature. One consumer doesn't justify new core API under the project's "two adapters = a real seam" rule. Revisit trigger: a second consumer, or a decision to privatizeproviders_registry.Docs-only;
just lint-ci(incl.check-planning) clean.🤖 Generated with Claude Code