docs: sync CLAUDE.md + architecture/ to post-audit code, archive findings - #71
Merged
Merged
Conversation
…ings The 2026-06-12 code audit shipped across 0.9.0 (#61/#66/#67) and 0.9.1 (#68/#69/#70), but the invariant docs still described pre-fix behavior. Sync the drift the audit flagged plus the drift its own fixes introduced, and retire the now-resolved findings doc. CLAUDE.md / architecture: - relay: `_OutboxConfigError` no longer "rides AcknowledgementMiddleware to the nack path" — the worker catches it, logs at ERROR, and the row retries via lease expiry, not the retry_strategy (P18). Fixed in both CLAUDE.md and architecture/relay.md. - terminal-write API: `delete_with_lease(conn, …)` / `mark_pending_with_lease(conn, …)`, not the `*_with_conn` names. - NOTIFY: over-long table names now raise ValueError at construction (P7), not "silently lose NOTIFY and degrade to polling". - engine ownership: drop the phantom `EngineState` holder and the dead `OutboxBrokerConfig.disconnect()` (removed in P24). - schema: note the P8 `<table>_lease_ck` CHECK; validate_schema now also probes partial-index predicates (S2). - drain regression-test references point at the real test names (T8 added them to test_fake.py; integration covers the Postgres path). - timers NOTIFY-skip: "genuinely future-dated" wording (a past/zero activate_at/in does fire NOTIFY). Archive: - move planning/active/2026-06-12-code-audit-findings.md → planning/archived/ with status: shipped + PR/release provenance. - repoint the two release-notes "See also" links to archived/. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two cleanups bundled (the loose ends after the 2026-06-12 code audit shipped in 0.9.0 + 0.9.1):
1. Doc-sync.
CLAUDE.mdandarchitecture/still described pre-fix behavior — the 6 drift items the audit flagged, plus drift its own fixes introduced. Now corrected:CLAUDE.md+relay.md)_OutboxConfigError"ridesAcknowledgementMiddlewareto the nack path, row retried"retry_strategy(P18)CLAUDE.mdworker loopdelete_with_lease_with_conn/mark_pending_with_lease_with_conndelete_with_lease(conn, …)/mark_pending_with_lease(conn, …)CLAUDE.mdNOTIFYmake_outbox_tableraisesValueErrorat construction (P7)CLAUDE.mdengine ownershipEngineStateholder;OutboxBrokerConfig.disconnect()disconnect()removed in P24,EngineStatenever existedCLAUDE.mdschema<table>_lease_ckCHECK;validate_schema()now probes partial-index predicates (S2)CLAUDE.md+drain.mdtest_drain_timeout*/test_broker_stop_runs_subscribers_in_parallel(didn't exist)test_fake.py; integration covers Postgres)timers.mdactivate_in/activate_atis set"2. Archive. The findings doc is fully resolved (nothing deferred), so it moves
planning/active/ → planning/archived/withstatus: shipped+ PR/release provenance in the frontmatter. The two release-notes "See also" links are repointed to the new path.Verification
just lint-ciclean (ruff format/check, ty).test_drain_*,<table>_lease_ck,<table>_pending_idx,timer_id_uq) verified to exist in the code.🤖 Generated with Claude Code