Skip to content

fix: resolve .js subpath types in Deno - #2740

Closed
mikemikimike wants to merge 1 commit into
modelcontextprotocol:v1.xfrom
mikemikimike:fix/2701-deno-subpath-types-v1
Closed

mikemikimike wants to merge 1 commit into
modelcontextprotocol:v1.xfrom
mikemikimike:fix/2701-deno-subpath-types-v1

Conversation

@mikemikimike

Copy link
Copy Markdown

Summary

  • add an explicit ./*.js export pattern so Deno maps .js subpaths to the emitted declaration files
  • preserve Node ESM and CommonJS subpath resolution
  • add a regression test for the export targets

Fixes #2701

Validation

  • npm test -- --run test/issues/test_2701_deno_subpath_exports.test.ts
  • npm run typecheck
  • Windows-safe ESM/CJS TypeScript compilation
  • targeted Prettier and ESLint checks pass
  • full npm test ran 53 files / 1646 tests but exited 1 because two existing Windows stdio tests emitted unhandled JSON parse errors

@mikemikimike
mikemikimike requested a review from a team as a code owner August 30, 2026 04:03
@changeset-bot

changeset-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 197ef19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Aug 30, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@modelcontextprotocol/sdk@2740

commit: 197ef19

@mikemikimike

Copy link
Copy Markdown
Author

Closing this duplicate PR because Issue #2701 already has the existing open PR #2702 addressing the same fix. No further action is requested from maintainers.

@mikemikimike
mikemikimike deleted the fix/2701-deno-subpath-types-v1 branch August 30, 2026 04:05
@claude claude Bot added the v1 Issues / PRs related to v1.x label Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v1 Issues / PRs related to v1.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant