fix(everything-server): normalize streamed tool responses - #462
Open
lucarlig wants to merge 1 commit into
Open
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
lucarlig
marked this pull request as ready for review
August 18, 2026 09:49
Author
|
@pcarleton @felixweinberger, could one of you approve the first-time-contributor Actions runs and review this focused everything-server fix? It resolves #461 and has full local validation: 531/531 tests, build, check, and all seven streamed tool scenarios on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normalizes streamed
tools/callresults from the bundled TypeScript everything-server so modern2026-07-28responses include the requiredresultType: "complete"discriminator.Motivation and Context
The stateless JSON response helper adds the required discriminator, but the streamed
tools/callbranch wrote SSE frames directly and bypassed that normalization. The bundled reference fixture therefore produced schema-invalid modern-wire results for all seven streamed tool-call fixture scenarios.This change centralizes stateless result normalization, applies it before both JSON and SSE output, and extends the existing fixture-to-fixture coverage to all seven streamed tool scenarios.
Fixes #461.
How Has This Been Tested?
npm test -- src/scenarios/server/all-scenarios.test.ts— 55/55 tests passed, including all seven streamed tool scenarios on the2026-07-28wirenpm test— 44 test files, 531/531 tests passednpm run checknpm run buildnode dist/index.js server --url http://127.0.0.1:43117/mcp --spec-version 2026-07-28 --scenario tools-call-simple-text --verbose— 2/2 checks passedBreaking Changes
None. This corrects the bundled reference fixture's output to match the
2026-07-28wire schema. It does not change public CLI, configuration, scenario, or check-ID interfaces.Types of changes
Checklist
Additional context
This is a focused reference-fixture correction and regression test. It does not add or change a conformance scenario, requirement, or check ID, so scenario registration, traceability updates, and external SDK validation are not applicable. No new error paths or documentation requirements are introduced.