[17.06] Disable hostname lookup on chain exists check - #1990
Merged
Merged
Conversation
Contributor
Author
fcrisciani
self-requested a review
October 18, 2017 18:12
|
LGTM |
cpuguy83
approved these changes
Oct 18, 2017
cpuguy83
left a comment
cpuguy83
left a comment
Member
There was a problem hiding this comment.
LGTM
CircleCI doesn't like it though.
Without `-n`, iptables will attempt to lookup hostnames for IP addresses, which can slow down the call dramatically. Since we don't need this, and generally don't even care about the output, use the `-n` flag to disable this. Signed-off-by: Brian Goff <cpuguy83@gmail.com> (cherry picked from commit 8dce207) Signed-off-by: Andrew Hsu <andrewhsu@docker.com>
Contributor
Author
|
@cpuguy83 with persistence, was able to get a green build; looked like a missing code coverage token for the previous failures |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of fix:
With cherry-pick of commit 8dce207:
No conflicts.