Repository navigation
bump docker/docker to master and unfork dependencies - #1975
Merged
Merged
Conversation
Member
Author
|
Looks like some changes are needed in the |
Member
Author
|
I'll need to make the same modifications as are made here; moby/moby@e942513#diff-e1546f0e7fe0b238191ff0cb82342936 |
thaJeztah
force-pushed
the
unfork-docker
branch
from
October 8, 2017 11:47
4281e24 to
b344adb
Compare
Member
Author
|
Updated, all green now 👍 |
Codecov Report
@@ Coverage Diff @@
## master #1975 +/- ##
=========================================
Coverage ? 38.04%
=========================================
Files ? 137
Lines ? 27362
Branches ? 0
=========================================
Hits ? 10411
Misses ? 15681
Partials ? 1270Continue to review full report at Codecov.
|
|
Fixes: #1899 |
|
LGTM, but I would like also @mavenugo to take a look |
This patch updates all dependencies to match what is used in moby/moby. Making the dependencies match what is used in that repository makes sure we test with the same version as libnetwork is later built with in moby. This also gets rid of some temporary forks that were needed during the migration of Sirupsen/logrus to sirupsen/logrus. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
unfork-docker
branch
from
October 25, 2017 15:26
b344adb to
873af34
Compare
Contributor
|
For this change, If CI is happy, am happy :) |
Member
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch updates all dependencies to match what is used in moby/moby. Making the dependencies match what is used in that repository makes sure we test with the same version as libnetwork is later built with in moby.
This also gets rid of some temporary forks that were needed during the migration of Sirupsen/logrus to sirupsen/logrus.
ping @fcrisciani @abhi LMK if you think this is a good thing to do; I started this to just get rid of the forks, but noticed the version of the dependencies used here were very outdated, compared with what's used in Docker, so decided to try and bump those to what's currently used there.