Repository navigation
testutil: add binary and extraEnv opt for dockerd worker - #4736
Merged
Merged
Conversation
crazy-max
force-pushed
the
test-multi-dockerd
branch
7 times, most recently
from
March 7, 2024 09:45
51a7fa2 to
c9a8f97
Compare
crazy-max
marked this pull request as ready for review
March 7, 2024 12:53
jedevc
reviewed
Mar 7, 2024
crazy-max
force-pushed
the
test-multi-dockerd
branch
from
March 7, 2024 13:37
c9a8f97 to
8705bf3
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
test-multi-dockerd
branch
from
March 7, 2024 14:24
8705bf3 to
c3b0f43
Compare
Member
Author
|
@jedevc Actually I don't think we need to handle extra dockerd versions here. This is done in buildx repo instead: docker/buildx#2307. |
tonistiigi
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to docker/buildx#2307