Skip to content

testutil: add binary and extraEnv opt for dockerd worker - #4736

Merged
crazy-max merged 1 commit into
moby:masterfrom
crazy-max:test-multi-dockerd
Mar 7, 2024
Merged

crazy-max merged 1 commit into
moby:masterfrom
crazy-max:test-multi-dockerd

Conversation

@crazy-max

@crazy-max crazy-max commented Mar 5, 2024 •

Copy link
Copy Markdown
Member

related to docker/buildx#2307

@crazy-max
crazy-max force-pushed the test-multi-dockerd branch 7 times, most recently from 51a7fa2 to c9a8f97 Compare March 7, 2024 09:45
@crazy-max
crazy-max requested review from jedevc and tonistiigi March 7, 2024 12:53
@crazy-max
crazy-max marked this pull request as ready for review March 7, 2024 12:53
Comment thread util/testutil/workers/dockerd.go Outdated
Comment thread util/testutil/workers/dockerd.go Outdated
Comment thread util/testutil/workers/dockerd.go Outdated
Comment thread util/testutil/workers/dockerd.go Outdated
@crazy-max
crazy-max force-pushed the test-multi-dockerd branch from c9a8f97 to 8705bf3 Compare March 7, 2024 13:37
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@crazy-max
crazy-max force-pushed the test-multi-dockerd branch from 8705bf3 to c3b0f43 Compare March 7, 2024 14:24
@crazy-max crazy-max changed the title testutil: allow specifying multiple dockerd versions testutil: add binary and extraEnv opt for dockerd worker Mar 7, 2024
@crazy-max

Copy link
Copy Markdown
Member Author

@jedevc Actually I don't think we need to handle extra dockerd versions here. This is done in buildx repo instead: docker/buildx#2307.

@crazy-max
crazy-max merged commit 588dafa into moby:master Mar 7, 2024
@crazy-max
crazy-max deleted the test-multi-dockerd branch March 7, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants