Repository navigation
Contract PartySpec, the party an adventure is written for - #146
Merged
Merged
Conversation
Adds Adventure.party, an optional PartySpec of character levels and party size. Nothing in the engine reads it. re-pod's playtest needs it to make a party that fits a module, and osr-forge will fill it from the module. Claude-Session: https://claude.ai/code/session_01YawzxEyAff8ovZSDzNmMAK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the contract for chunk
party-spec. It adds an optionalAdventure.party, of typePartySpec: the character levels an adventure is written for and, when the module says, the party size. Nothing in the engine reads it. re-pod's FRUA playtest uses it to make a party that fits a module, and osr-forge will fill it from the module.The field is additive, so
SCHEMA_VERSIONdoesn't move. The validator is a stub. Its tests are marked xfail withraises=NotImplementedError, and so is thePartySpecdocstring example in both docs-example tests.The same field will also be released as osrlib 1.8.0, from a branch cut from the v1.7.1 tag.
https://claude.ai/code/session_01YawzxEyAff8ovZSDzNmMAK