Skip to content

Conjugate VJP and JVP support - #3386

Merged
angeloskath merged 1 commit into
ml-explore:mainfrom
CameronChurchwell:main
Apr 9, 2026
Merged

angeloskath merged 1 commit into
ml-explore:mainfrom
CameronChurchwell:main

Conversation

@CameronChurchwell

@CameronChurchwell CameronChurchwell commented Apr 8, 2026 •

Copy link
Copy Markdown
Contributor

VJP and JVP implementations for the conjugate primitive

Currently, the complex conjugate operation is not supported by the autograd because the underlying Conjugate primitive does not have vjp or jvp definitions. This PR adds those missing definitions.

I also added a few lines to the test_conjugate unit test in python/tests/test_ops.py that cover both vjp and jvp calls for conjugate. To my knowledge, no documentation changes are necessary.

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@angeloskath angeloskath left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks!

@angeloskath
angeloskath merged commit d6d9b24 into ml-explore:main Apr 9, 2026
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Apr 22, 2026
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants