Skip to content

feat: Add Dropout3d layer to nn.layers - #313

Merged
awni merged 8 commits into
ml-explore:mainfrom
NripeshN:dropout3d
Dec 31, 2023
Merged

awni merged 8 commits into
ml-explore:mainfrom
NripeshN:dropout3d

Conversation

@NripeshN

@NripeshN NripeshN commented Dec 29, 2023 •

Copy link
Copy Markdown
Contributor

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

@NripeshN

Copy link
Copy Markdown
Contributor Author

Hey @awni
I am not sure if I should be adding tests here. I could not find tests for dropout2d and dropout.

@awni

awni commented Dec 29, 2023

Copy link
Copy Markdown
Member

If you are up for adding a couple tests that would be fantastic! They can be pretty simple, like just check shapes are preserved, dtypes are preserved, we throw correctly on bad p, etc.

@NripeshN

Copy link
Copy Markdown
Contributor Author

If you are up for adding a couple tests that would be fantastic! They can be pretty simple, like just check shapes are preserved, dtypes are preserved, we throw correctly on bad p, etc.

Done!

@awni awni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and thanks for adding the tests! Two minor comments, please address then we can merge!

Comment thread ACKNOWLEDGMENTS.md Outdated
Comment thread python/tests/test_nn.py
@NripeshN
NripeshN requested a review from awni December 31, 2023 22:00

@awni awni left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 thanks!

@awni
awni merged commit e09bf35 into ml-explore:main Dec 31, 2023
@NripeshN
NripeshN deleted the dropout3d branch December 31, 2023 22:02
JayYun98 pushed a commit to JayYun98/mlx that referenced this pull request Jan 7, 2024
* feat: Add Dropout3d layer to nn.layers

* acknowledgement

* Add dropout tests to test_nn.py

* run pre-commit

* Add activation functions and dropout3d ops

* Add dropout tests for bfloat16 and float16
zcbenz pushed a commit to Ritabanm/mlx that referenced this pull request Sep 30, 2026
…x-dtypes

Avoid calling hh.arrays with dtype=None for complex types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants