Repository navigation
feat: Add Dropout3d layer to nn.layers - #313
Merged
Merged
Conversation
Contributor
Author
|
Hey @awni |
Member
|
If you are up for adding a couple tests that would be fantastic! They can be pretty simple, like just check shapes are preserved, dtypes are preserved, we throw correctly on bad |
Contributor
Author
Done! |
awni
requested changes
Dec 31, 2023
awni
left a comment
Member
There was a problem hiding this comment.
Looks great and thanks for adding the tests! Two minor comments, please address then we can merge!
JayYun98
pushed a commit
to JayYun98/mlx
that referenced
this pull request
Jan 7, 2024
* feat: Add Dropout3d layer to nn.layers * acknowledgement * Add dropout tests to test_nn.py * run pre-commit * Add activation functions and dropout3d ops * Add dropout tests for bfloat16 and float16
zcbenz
pushed a commit
to Ritabanm/mlx
that referenced
this pull request
Sep 30, 2026
…x-dtypes Avoid calling hh.arrays with dtype=None for complex types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes