Repository navigation
feat(analytics): Add getAllVariantsByFlag - #70
Merged
Merged
Conversation
tylerjroach
changed the title
efahk
approved these changes
Apr 28, 2026
efahk
left a comment
efahk
left a comment
Contributor
There was a problem hiding this comment.
thanks, this'll match the other libs implementations more closely
JianingL
approved these changes
Apr 29, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getAllVariantswas missing flagKey for each variant. To resolve this, we created a newgetAllVariantsByFlagwith a return type map offlagKey to SelectedVariant<Object>Deprecating
getAllVariantsas we would expect usage to move togetAllVariantsByFlagWill resolve #68