Repository navigation
Conversation
The vite.build.config.ts of components, remote-elements,
remote-react-components, remote-react-renderer and
mstudio-ext-react-components imports the build checks and
publishedDtsOptions from packages/core/src. Their build targets list
explicit inputs, which drops the implicit ^default, so no core file
was hashed: a change to the guard served those builds from cache
without running it.
Add {workspaceRoot}/packages/core/src/**/* to each. ext-bridge,
react-tunnel and remote-core keep the default inputs, whose ^default
already covers core through their workspace dependency.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five
buildtargets import the build checks andpublishedDtsOptionsfrompackages/core/srcin theirvite.build.config.ts, but nx hashed no core file for them. A change to the guard served those builds from cache without running it.Cause: these targets list explicit
inputs, which replaces the implicit["default", "^default"]. Without^default, the workspace dependency on@mittwald/flow-corecontributes nothing to the hash.Fix: add
{workspaceRoot}/packages/core/src/**/*to thebuildinputs of:componentsremote-elementsremote-react-componentsremote-react-renderermstudio-ext-react-componentsext-bridge,react-tunnelandremote-corealso import core. They keep the default inputs, whose^defaultalready hashes core, so they stay unchanged. Test andbuild:scss-typestargets already hash core.Verification
nx show target inputs <pkg>:build --check packages/core/src/publishedDtsOptions.tspasses for all eight packages.packages/core/srcfiles. Nothing dropped.nx run-many -t buildover the five targets:packages/core/src/publishedDtsOptions.ts: all eight core-importing builds reran.tokens,iconsandicons-prostayed cached.🤖 Generated with Claude Code