Skip to content

build: hash core sources in remote package builds - #3441

Draft
mfal wants to merge 1 commit into
mainfrom
claude/nx-core-src-build-inputs
Draft

mfal wants to merge 1 commit into
mainfrom
claude/nx-core-src-build-inputs

Conversation

@mfal

@mfal mfal commented Oct 9, 2026

Copy link
Copy Markdown
Member

Five build targets import the build checks and publishedDtsOptions from packages/core/src in their vite.build.config.ts, but nx hashed no core file for them. A change to the guard served those builds from cache without running it.

Cause: these targets list explicit inputs, which replaces the implicit ["default", "^default"]. Without ^default, the workspace dependency on @mittwald/flow-core contributes nothing to the hash.

Fix: add {workspaceRoot}/packages/core/src/**/* to the build inputs of:

  • components
  • remote-elements
  • remote-react-components
  • remote-react-renderer
  • mstudio-ext-react-components

ext-bridge, react-tunnel and remote-core also import core. They keep the default inputs, whose ^default already hashes core, so they stay unchanged. Test and build:scss-types targets already hash core.

Verification

  • nx show target inputs <pkg>:build --check packages/core/src/publishedDtsOptions.ts passes for all eight packages.
  • Resolved input lists before and after differ only by the six packages/core/src files. Nothing dropped.
  • nx run-many -t build over the five targets:
    • Warm run: 19/19 tasks from cache.
    • After a content change in packages/core/src/publishedDtsOptions.ts: all eight core-importing builds reran. tokens, icons and icons-pro stayed cached.

🤖 Generated with Claude Code

The vite.build.config.ts of components, remote-elements,
remote-react-components, remote-react-renderer and
mstudio-ext-react-components imports the build checks and
publishedDtsOptions from packages/core/src. Their build targets list
explicit inputs, which drops the implicit ^default, so no core file
was hashed: a change to the guard served those builds from cache
without running it.

Add {workspaceRoot}/packages/core/src/**/* to each. ext-bridge,
react-tunnel and remote-core keep the default inputs, whose ^default
already covers core through their workspace dependency.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mfal mfal self-assigned this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 78.12% 1314 / 1682
🔵 Statements 77.85% 1350 / 1734
🔵 Functions 72.46% 300 / 414
🔵 Branches 71.81% 698 / 972
File CoverageNo changed files found.
Generated in workflow #7189 for commit 2ee3eb8 by the Vitest Coverage Report Action

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Preview Deployment

Preview environments are ready:

Type URL
docs pr-3441.docs.review.flow-components.de
storybook pr-3441.storybook.review.flow-components.de

Images:

  • docs: ghcr.io/mittwald/flow/docs:pr-3441
  • storybook: ghcr.io/mittwald/flow/storybook:pr-3441

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant