Repository navigation
Conversation
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
Lisa18289
force-pushed
the
claude/accordion-component-review-15064b
branch
from
October 8, 2026 08:31
2c44ec6 to
eb0b759
Compare
…arch Stacked accordions inherited their parent's gap, a Label header left the accordion out of the page outline, badges broke out of the toggle, and collapsed content was invisible to find-in-page. Closes #1838. `AccordionGroup` renders accordions as one block with separators. Single-expand is opt-in, and the controlled state uses React Aria's prop names. The group keeps its own expansion state, because `DisclosureGroup` ignores an item's `defaultExpanded`. The Accordion builds on `useDisclosure`: collapsed panels are `hidden="until-found"` and expand on a find match, so Flow's `Activity` no longer defers their content. `Heading` stays a heading (`h3` by default), `Text` and `Label` render a compact toggle. `variant` is deprecated as a whole; `"outline"` no longer draws a frame. The migration entry `accordion-variant-deprecated` removes the prop with a codemod. Header and content text sit on the surrounding content's edge, heading spacing follows `section.spacing`, Navigation moves onto the menu tokens, and the List's filter modal groups its accordions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lisa18289
force-pushed
the
claude/accordion-component-review-15064b
branch
from
October 9, 2026 05:38
d184a48 to
ab7f383
Compare
| padding-x: | ||
| value: "{size-px.s}" | ||
| padding-y: | ||
| value: "{size-px.s}" |
Member
There was a problem hiding this comment.
wenn Padding x und padding y beide auf size s gehen könnten wir einfach nur Padding haben. Unten text-padding und content-padding ist ja okay wenn diese noch mal spezieller sind.
| value: "{size-px.s}" | ||
| padding-y: | ||
| value: "{size-px.s}" | ||
| text-padding-y: |
Member
There was a problem hiding this comment.
Frage sollten wir nicht lieber padding-text-y als token schreiben ich glaube so haben wir es doch auch immer beim rest gleiches gilt für content und header.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked accordions inherited their parent's gap and read as separate, bulky blocks; a Label header left the accordion out of the page outline; badges in the header broke out of the toggle; and collapsed content was invisible to find-in-page. Closes #1838.
AccordionGrouprenders its accordions as one block with separators, so the parent's gap only applies around it. Single-expand is opt-in, and the controlled state uses React Aria's prop names. The group keeps its own expansion state instead of usingDisclosureGroup, which ignores an item'sdefaultExpanded.The Accordion builds on
useDisclosure: collapsed panels arehidden="until-found"and expand on a find match, which drops Flow'sActivityfrom the accordion.Headingstays a heading (nowh3by default, at its own font size),Textrenders a plain toggle with a smaller chevron.Labelrenders a plain toggle as well.variantis deprecated as a whole:"outline"no longer draws a frame, so the prop has no effect left and warns when passed. The migration entryaccordion-variant-deprecatedremoves it with a codemod and points toAccordionGroupfor separators. Header and content text sit on the surrounding content's edge via a negative inline margin, and heading spacing followssection.spacingand the section's sub-heading spacing. Navigation moves onto the menu tokens with the same alignment, and the List's filter modal groups its accordions.Collapsed content now always mounts, so find-in-page reaches it. Flow's
Activityno longer defers it until expansion: effects and data loading inside a collapsed accordion run on page load. Every consumer still passingvariant="outline"loses the frame.Worth a look: the new
accordion.*token values were tuned in review, not by UX; the default heading level moves from 4 to 3, which changes every accordion without an explicit level.🤖 Generated with Claude Code