Repository navigation
Conversation
A pending, succeeded, failed or aria-disabled MenuItem ignored presses, but react-aria dropped aria-disabled from the DOM, so the item was announced as enabled. The muted item now renders aria-disabled through react-aria's render prop. Muting also strips onAction, which Action uses, and cancels the item's click, Enter and Space: react-aria runs the menu's onAction, follows the href and toggles the selection on those. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Coverage Report for ./packages/components/
File CoverageNo changed files found. |
Contributor
🚀 Preview DeploymentPreview environments are ready:
Images:
|
- Ignore a mouse release on a muted item that started outside it, which selected the item on pointer up - Stop propagation of muted clicks and Enter/Space, as React Aria does - Test Enter on a muted link and a custom render function, and reset the location hash after each test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pending, succeeded, failed or
aria-disabledMenuItem ignores presses, but react-aria dropsaria-disabledfrom the DOM, so screen readers announced an enabled item. Muted items now renderaria-disabled="true"through react-aria'srenderprop.Muting also had gaps that become visible once the item is announced as disabled:
onActionwas not stripped, so a pending item inside anActioncould run again.ContextMenu'sonAction, follows thehrefand toggles the selection. The muted render cancels the click.Like react-aria's own handlers, the muted ones stop the event. A click on a muted item no longer closes the menu, and a consumer's
onClick, oronKeyDownfor Enter and Space, no longer runs. Select all and Cmd+A still include muted items. The item stays focusable, as ARIA recommends for disabled menu items.Consumer test suites notice the change, as with #3318: Playwright treats
aria-disabledas disabled, soclick()on a muted menu item waits until it is enabled again and times out.Split out of #3318.
🤖 Generated with Claude Code