Skip to content

Upstream prep - #79

Merged
alilleybrinker merged 14 commits into
pact_matching_ffifrom
upstream_prep
Apr 22, 2021
Merged

Upstream prep#79
alilleybrinker merged 14 commits into
pact_matching_ffifrom
upstream_prep

Conversation

@alilleybrinker

@alilleybrinker alilleybrinker commented Apr 20, 2021

Copy link
Copy Markdown

Preparing for submission upstream.

@alilleybrinker alilleybrinker added A-docs Area: Documentation A-ffi Area: Foreign Function Interface C-auditing Category: Auditing code for style and best practices. T-upstreaming Topic: Work related to getting our changes submitted upstream. labels Apr 20, 2021
@alilleybrinker alilleybrinker added this to the April 2021 milestone Apr 20, 2021
cstepanian
cstepanian reviewed Apr 22, 2021
View reviewed changes
Comment thread rust/pact_matching_ffi/ARCHITECTURE.md Outdated
cstepanian
cstepanian reviewed Apr 22, 2021
View reviewed changes
Comment thread rust/pact_matching_ffi/ARCHITECTURE.md Outdated
cstepanian
cstepanian reviewed Apr 22, 2021
View reviewed changes
Comment thread rust/pact_matching_ffi/src/models/message.rs Outdated
cstepanian
cstepanian reviewed Apr 22, 2021
View reviewed changes
Comment thread rust/pact_matching_ffi/src/models/consumer.rs
cstepanian
cstepanian reviewed Apr 22, 2021
View reviewed changes
Comment thread rust/pact_matching_ffi/src/models/provider.rs
cstepanian
cstepanian approved these changes Apr 22, 2021
View reviewed changes

@cstepanian cstepanian left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@alilleybrinker
alilleybrinker merged commit c5fd1cb into pact_matching_ffi Apr 22, 2021
@alilleybrinker
alilleybrinker deleted the upstream_prep branch April 22, 2021 16:49
alilleybrinker added a commit that referenced this pull request Apr 22, 2021
@alilleybrinker
Upstream prep (#79)
bd02e36 
Final preparation of documentation and examples before submitting this work to upstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cstepanian cstepanian cstepanian approved these changes

Assignees

No one assigned

Labels

A-docs Area: Documentation A-ffi Area: Foreign Function Interface C-auditing Category: Auditing code for style and best practices. T-upstreaming Topic: Work related to getting our changes submitted upstream.

Projects

None yet

Milestone

April 2021

Development

Successfully merging this pull request may close these issues.

2 participants

@alilleybrinker @cstepanian