[ankostis]

FIX #10 to be possible to preserve the matched captures.

Previously all matches were passed through os.path.normcase(), which in Windows, it converts them to lower-cases.
The resulting matches would then break user-code when it runs on POSIX and non-POSIX systems (e.g. running a Makefile-like python tool).
Note that python stdlib does not by default pass al filepaths through normcase() - this is left to the discretion of the user.

• Contains also a fix commit( b777c1f) where the lru_cache was not actually used. Was that your intention @miracle2k?
• Test-cases run OK on Linux python 2 & 3 and CYGWIN python-2 (cannot run in pure Windows python because test-cases are written for forward slash OS).
• Performance degradation is negligible on the above platforms, as measured by running the test-cases 10 times (I know, this in not a big workload).

[miracle2k]

Looks good, thanks for the patch.

[miracle2k]

The LRU bug was introduced here :( 6876675#diff-b702bab9f1fd8e250b7d429a75486ba2L38

[ankostis]

By the way, to really fix case-conversion of matches(#10), the defaults must change to:

norm_paths=False, case_sensitive='nt' in os.name

[miracle2k]

You mean there is something else to be done here?

Actually, looking at it more, I think we broke backwards compatibility here. The behaviour changed from not caring about case-sensitivity, to caring about it by default. Am I wrong?

[ankostis]

This PR preserves the behavior of the library, but library's behavior so far did not preserve the case of matches.
And this is not what Python's os.path and pathib functions do.

So I said that in order to imitate Python's behavior, you need to set the defaults I described above in the various keyword-arguments.
Such a breaking change would deserve a separate PR/commit.

Does that make sense?

[ankostis]

You mean there is something else to be done here?

Yes.
Just to be clear before for the next release,
I believe that the defaults for Windows when with_matches=True has to be these:

glob2.glob('stab.*', with_matches=True, case_sensitive=False, norm_paths=False)

and a note that if the program runs also in POSIX, adding sep='/' also helps portability.