Repository navigation
MOBILE-635: Drop an in-app whose frequency or display condition cannot be read - #840
Merged
Merged
Conversation
…t be read A missing or null value still means the default: once per lifetime for frequency, no conditions for displayConditions. Anything else the SDK cannot read now drops only that in-app, the same way iOS does. Before, an unknown or malformed displayConditions read as no conditions, so direct-call story content showed by itself on start. An unknown frequency read as once per lifetime, and a null or non-object frequency failed the whole inapps block.
sergeysozinov
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/MOBILE-635
Нечитаемые
frequencyиdisplayConditionsтеперь выбрасывают только свой инапп, как на iOS (MOBILE-499). Отсутствующее поле иnullдают прежний дефолт:once/lifetimeи «без условий».InAppDtoBlankхранит сырыеfrequencyиdisplayConditionsкакJsonElement?, чтобы отличать «поля нет» от «не прочитано»;NullSafeJsonObjectDeserializerудалён.MobileConfigRepositoryImpl.getInAppsразбирает поля и отбрасывает инапп черезmapNotNull, лог —logParseFailure."frequency": nullи не-объект больше не роняют разбор всего конфига.InAppRestrictionFieldsTest: 21 кейс, в каждом проверяется, что соседний инапп выжил.