Skip to content

Task/refactor packaging - #144

Merged
Samwel K. (samwelkanda) merged 4 commits into
kiota/long-term-branchfrom
task/refactor-packaging
Nov 21, 2022
Merged

Task/refactor packaging#144
Samwel K. (samwelkanda) merged 4 commits into
kiota/long-term-branchfrom
task/refactor-packaging

Conversation

@samwelkanda

@samwelkanda Samwel K. (samwelkanda) commented Nov 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

  • Refactors package structure to use src folder for easy installs
  • Switch from flit to setuptools for packaging and easier imports e.g
#old format
from msgraph.core.base_graph_request_adapter import BaseGraphRequestAdapter
#new format
from msgraph_core import BaseGraphRequestAdapter

@samwelkanda
Samwel K. (samwelkanda) marked this pull request as ready for review November 21, 2022 13:03
@samwelkanda
Samwel K. (samwelkanda) merged commit 0487b2c into kiota/long-term-branch Nov 21, 2022
@samwelkanda
Samwel K. (samwelkanda) deleted the task/refactor-packaging branch November 21, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baywet Vincent Biret (baywet) baywet approved these changes
@andrueastman Andrew Omondi (andrueastman) Awaiting requested review from andrueastman

Assignees

@samwelkanda Samwel K. (samwelkanda)

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samwelkanda @baywet