Repository navigation
Closed
Labels
area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environmentsdebtCode quality issuesCode quality issues
Milestone
Description
This will involve the following:
- change
PythonExecutionService.pythonPath(a string) toPythonExecutionService.pyArgv(an array of strings)- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonProcess.ts
- rename
- update
PythonExecutionServiceaccordingly
- update
PythonExecutionService.create()to pass an array of strings toPythonExecutionService()- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
- determine if conda or not (and set
pyArgvaccordingly) - update the call sites
- update
PythonExecutionService.createActivatedEnvironment()to pass an array of strings toPythonExecutionService()- https://github.com/microsoft/vscode-python/blob/master/src/client/common/process/pythonExecutionFactory.ts
- determine if conda or not (and set
pyArgvaccordingly) - update the call sites
- verify that the usage in the various places works properly for conda and non-conda:
- formatting
src/client/formatters/baseFormatter.ts(viaPythonToolExecutionService)
- linting
src/client/linters/errorHandlers/notInstalled.tssrc/client/linters/baseLinter.ts(viaPythonToolExecutionService)
- testing
src/client/testing/common/services/discovery.tssrc/client/testing/common/runner.tssrc/client/testing/common/runner.ts(viaPythonToolExecutionService)
- installers
src/client/common/installer/pipInstaller.tssrc/client/common/installer/productInstaller.ts
- debugger
src/client/debugger/extension/adapter/factory.ts
- interpreter discovery
src/client/interpreter/locators/services/workspaceVirtualEnvWatcherService.tssrc/client/interpreter/configuration/pythonPathUpdaterService.tssrc/client/interpreter/helpers.tssrc/client/interpreter/interpreterService.tssrc/client/interpreter/locators/services/windowsStoreInterpreter.ts
- import sorting
src/client/providers/importSortProvider.ts
- jedi
src/client/providers/jediProxy.ts
- refactoring
src/client/refactor/proxy.ts
- formatting
Metadata
Metadata
Assignees
Labels
area-environmentsFeatures relating to handling interpreter environmentsFeatures relating to handling interpreter environmentsdebtCode quality issuesCode quality issues
Activity
kimadeline commentedon Oct 23, 2019
Make sure
conda runworks with both named environment and non-named environment (where we have to use the path)kimadeline commentedon Nov 25, 2019
To validate:
conda create --name yourenvorconda create -n yourenv)conda runconda runconda runconda runconda create --prefix path/to/env)conda runconda runconda runconda runkarrtikr commentedon Nov 25, 2019
validated
karrtikr commentedon Nov 25, 2019
Found an unrelated issue while validating it. #8783