Skip to content

Fix localized Conda named environment creation - #1770

Merged
Eduardo Villalpando Mello (edvilme) merged 5 commits into
mainfrom
copilot/fix-conda-environment-creation
Sep 8, 2026
Merged

Fix localized Conda named environment creation#1770
Eduardo Villalpando Mello (edvilme) merged 5 commits into
mainfrom
copilot/fix-conda-environment-creation

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Conda named environment creation could silently route to the prefix flow when VS Code used a translated display language. The flow stored the localized “Named” label, then compared it against the English literal "Named".

  • Conda creation flow
    • Compare against CondaStrings.condaNamed instead of a hard-coded English string.
    • Keep the multi-workspace “force named environment” path consistent with the localized discriminator.
return state.envType === CondaStrings.condaNamed ? enterEnvironmentName : selectLocation;
  • Regression coverage
    • Added a focused unit test that simulates a localized “Named” label and verifies the flow prompts for an environment name and calls named Conda creation.

Co-authored-by: edvilme <5952839+edvilme@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix conda environment creation issue in non-English display languages Fix localized Conda named environment creation Sep 8, 2026
Co-authored-by: edvilme <5952839+edvilme@users.noreply.github.com>
@edvilme
Eduardo Villalpando Mello (edvilme) marked this pull request as ready for review September 8, 2026 21:49
@edvilme Eduardo Villalpando Mello (edvilme) added the bug Issue identified by VS Code Team member as probable bug label Sep 8, 2026
Comment thread src/managers/conda/condaStepBasedFlow.ts
Co-authored-by: edvilme <5952839+edvilme@users.noreply.github.com>
@edvilme
Eduardo Villalpando Mello (edvilme) merged commit 66a6bc6 into main Sep 8, 2026
84 checks passed
@edvilme
Eduardo Villalpando Mello (edvilme) deleted the copilot/fix-conda-environment-creation branch September 8, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Conda "Named" environment creation silently does nothing when the display language is not English

5 participants