v8 - Add a way to push all available configurations (additively) - #74
Draft
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
Draft
v8 - Add a way to push all available configurations (additively)#74Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
Conversation
| * Push IntelliSense configurations for source files. | ||
| * A provider should push all custom configurations available, as soon as they are available, | ||
| * to support features such as whole codebase symbol indexing and for an accurate include graph. | ||
| * Configurations are additive. Call `didChangeCustomConfiguration` to clear all configurations. |
Member
There was a problem hiding this comment.
Calling didChangeCustomConfiguration will cause cpptools to immediately re-request configurations for all tracked files. Maybe it would be better to have this API add a parameter that signals for cpptools to clear any previous configurations instead.
| ``` | ||
| */ | ||
| readonly uri: string | vscode.Uri; | ||
| readonly uri: string | vscode.Uri | (string | vscode.Uri)[]; |
Member
There was a problem hiding this comment.
I don't like the idea of having this accept an array. It would be better to have a separate object for configurations that apply to multiple files.
| // Do any required setup that the provider needs. | ||
|
|
||
| // Notify cpptools that the provider is ready to provide IntelliSense configurations. | ||
| api.notifyReady(provider); |
Member
There was a problem hiding this comment.
The sample assumes that this API is available. Version checks should be done before any APIs are called to determine which initialization path to choose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minimal change to add an alternate (new preferred) usage model in which configuration providers can push all available configurations as soon as they are available, to allow (properly configured) eager analysis of those files by cpptools.