Repository navigation
Fix lsp start on MacOS - #442
Closed
Hoa Nguyen (nguhoa) wants to merge 2 commits into
Closed
Hoa Nguyen (nguhoa) wants to merge 2 commits into
Hoa Nguyen (nguhoa) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Explicit runtime overrides fail on unmapped hosts in both build and watch scripts.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Addresses #432 by packaging a native Apple Silicon language server and selecting host-matching runtimes for local development.
Changes:
- Package
osx-arm64binaries fordarwin-arm64. - Default build/watch scripts to the host runtime.
- Add architecture regression tests and update documentation.
| File | Description |
|---|---|
src/vscode-extensions/shared/scripts/hostRuntime.js |
Resolves host runtime identifiers. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/watchLsp.js |
Uses the host runtime by default. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/tests/packageVsix.test.js |
Checks packaging runtime selection. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/tests/lspBuildScripts.test.js |
Checks build/watch defaults and overrides. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/tests/hostRuntime.test.js |
Tests host runtime mappings. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/tests/helpers/targets.js |
Provides architecture comparison helpers. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/tests/extensionProj.test.js |
Checks MSBuild packaging architecture alignment. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/packageVsix.js |
Selects ARM64 for Apple Silicon packages. |
src/vscode-extensions/microsoft-powerplatformlang-extension/scripts/buildLsp.js |
Uses the host runtime by default. |
src/vscode-extensions/microsoft-powerplatformlang-extension/package.json |
Adds the packaging test command. |
src/vscode-extensions/microsoft-powerplatformlang-extension/extension.proj |
Stages ARM64 binaries before packaging. |
src/vscode-extensions/microsoft-powerplatformlang-extension/.vscodeignore |
Excludes packaging tests from VSIX files. |
AGENTS.md |
Documents runtime selection and packaging tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const rawArgs = process.argv.slice(2); | ||
|
|
||
| let target = 'win-x64'; | ||
| let target = getHostRuntimeIdentifier(); |
| const rawArgs = process.argv.slice(2); | ||
|
|
||
| let target = 'win-x64'; | ||
| let target = getHostRuntimeIdentifier(); |
Contributor
|
Fixed by #449 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lsp start on MacOS.
Fix: #432