[WIP]Make TestFx repo CPS Based by mayankbansal018 · Pull Request #411 · microsoft/testfx

Mayank Bansal (mayankbansal018) · 2018-04-26T15:35:34Z

Things to verify before pushing this:

Localization
Assembly, & File Version
Nugets Upgradation
Vsix Templates / Wizard
Run on VSO

First Iteration

Mayank Bansal (mayankbansal018) · 2018-04-27T12:31:50Z

dotnet bot (@dotnet-bot) test this please

Jayarani garg (jayaranigarg) · 2018-05-10T13:16:57Z

    <TestFxRoot Condition="$(TestFxRoot) == ''">..\..\..\</TestFxRoot>
  </PropertyGroup>
-  <Import Project="$(TestFxRoot)scripts\build\TestFx.Settings.targets" />
+  <Import Project="$(TestFxRoot)scripts\build\TestFx.Settings.Templates.targets" />


Why did we separate them?

Jayarani garg (jayaranigarg) · 2018-05-10T13:17:42Z

  <package id="MSTest.Internal.TestFx.Localized.Documentation" version="1.0.0-build-20170420-1" />
  <package id="vswhere" version="2.0.2" />
  <package id="Pdb2Pdb" version="1.1.0-beta1-62316-01" />
+  <package id="Microsoft.TestPlatform" version="15.5.0" />


Shouldn't we use 15.7 instead?

Jayarani garg (jayaranigarg) · 2018-05-10T13:53:34Z

+  <ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
+    <PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.1" />
+  </ItemGroup>
+  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">


Why a conditional package reference here?

Jayarani garg (jayaranigarg) · 2018-05-10T13:55:49Z


  <ItemGroup>
-    <PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.0" />
+    <PackageReference Include="Microsoft.TestPlatform.ObjectModel" Version="11.0.1" />


what is the difference between 11.0 and 11.1?

Jayarani garg (jayaranigarg) · 2018-05-10T13:56:10Z

-    <ErrorReport>prompt</ErrorReport>
-    <WarningLevel>4</WarningLevel>
-    <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <TargetFrameworks>netstandard1.3;net45</TargetFrameworks>


why are we building this for net45?

Jayarani garg (jayaranigarg) · 2018-05-10T14:03:12Z

-    <file src="Build\NetCore\MSTest.TestAdapter.props" target="build\netcoreapp1.0\" />
+    <file src="MSTest.CoreAdapter\netstandard1.3\Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.dll" target="build\netcoreapp1.0\" />
+    <file src="PlatformServices.Interface\netstandard1.3\Microsoft.VisualStudio.TestPlatform.MSTestAdapter.PlatformServices.Interface.dll" target="build\netcoreapp1.0\" />
+    <file src="MSTest.Core\netstandard1.1\Microsoft.VisualStudio.TestPlatform.TestFramework.dll" target="build\net45\" />


Nit: build\netcoreapp1.0\

Jayarani garg (jayaranigarg) · 2018-05-10T14:09:01Z

-    <file src="MSTest.CoreAdapter\ru\Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.resources.dll" target="\build\_common\ru" />
-    <file src="MSTest.CoreAdapter\tr\Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.resources.dll" target="\build\_common\tr" />
+    <!-- Resources -->
+    <file src="MSTest.CoreAdapter\netstandard1.3\zh-Hans\Microsoft.VisualStudio.TestPlatform.MSTest.TestAdapter.resources.dll" target="\build\_common\zh-Hans" />


Will discuss on where to keep resources offline..

Jayarani garg (jayaranigarg) · 2018-05-10T14:15:47Z

            var testAssetPath =
                Path.Combine(
                    Directory.GetParent(Directory.GetParent(Directory.GetParent(currentAssemblyPath).FullName).FullName).FullName,
-                    "artifacts",


Sarabjot Singh (singhsarab) · 2018-08-01T05:41:23Z

Mayank Bansal (@mayankbansal018) What is the status of this PR?

Jayarani garg (jayaranigarg) · 2018-08-30T10:09:48Z

Mayank Bansal (@mayankbansal018) : When are we planning to push this PR in? This issue #481 will also get resolved as part of this PR.

Mayank Bansal (mayankbansal018) · 2018-08-30T10:22:43Z

Jayarani garg (@jayaranigarg) , lets bring this in next sprint planning, the work is almost done, validations do remain.

Carlos Parra (parrainc) · 2018-10-17T21:44:41Z

Mayank Bansal (@mayankbansal018) are there any news about this PR?
Some opened issues depend on this changes in order to be fixed.

Mayank Bansal (mayankbansal018) · 2018-10-29T06:46:16Z

Carlos Parra (@parrainc) , Unfortunately I've not been able to prioritize this task, due to other tasks that I've in hand. As per the last status of this PR, I had moved the project to CPS, & everything was running fine.

I understand that there are a few bugs pending on this, because of which I would encourage if you would like to take this further, let me know if that would be possible, I would give you permission on my branch.

Carlos Parra (parrainc) · 2018-10-29T16:12:09Z

Mayank Bansal (@mayankbansal018) i understand.
You can count me in, it would be a pleasure to take this further. I'll make sure to get this done asap, so those few issues that depends on this changes got closed soon 👍

in any case, if questions arise on the road, i'll be commenting here :)

Mayank Bansal (mayankbansal018) · 2018-10-29T16:25:45Z

Carlos Parra (@parrainc), great to hear this, I've added you as collaborator, on my from, please checkout branch makeTestFxCPS. You will have to merge master back into this, since the branch would be pretty behind. Please do comment back here in case you need any help.

👍 😃

…eTestFxCPS

Carlos Parra (parrainc) · 2018-11-07T12:54:10Z

Mayank Bansal (@mayankbansal018) quick question... is there a specific reason of why we are upgrading to netstandard 1.3 instead of a major version (i.e. 1.5, 1.6) or the latest one (2.0)? I'm not sure if latest or a different version than 1.3 is not fully compatible with some of the projects in the solution. If that's not the case then I'm just curious to know what could be done about it.

Morten Nielsen (dotMorten) · 2018-11-07T14:30:32Z

Carlos Parra (@parrainc) why upgrade to a version higher than needed? The higher the version, the fewer the platforms can use it

Mayank Bansal (mayankbansal018) · 2018-11-11T10:09:29Z

Carlos Parra (@parrainc) , as dotMorten mentioned, the lower the version for .net standard, the wider the range for platforms we can cover. For e.g. if we move to > NS1.4, then it won't work with UWP, & we would need to have separate build scripts to fix that.

Carlos Parra (parrainc) · 2018-11-13T21:35:19Z

gotcha

…eTestFxCPS

Carlos Parra (parrainc) · 2018-11-13T21:48:48Z

Mayank Bansal (@mayankbansal018) quick update:
did some change to sync up master with testFxCPS branch, and everything is going fine (building ok in VS, and unit and integration tests seems to behave just fine). The only issue I'm having is that while building from CLI, the following error shows up:

C:\Program Files\dotnet\sdk\2.1.403\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDepedencyResolution.targets(198,5): error NETSDK1005: Assets file 'C:...\testfx\src\Adapter\MSTest.CoreAdapter\obj\project.assets.json' doesn't have a target for '.NETFramework,Version=4.6'. Ensure that restore has run and that you have included 'net46' in the TargetFrameworks for your project. [Path to MSTest.CoreAdapter.csproj]

and the same for PlatformServices.Interface.csproj and PlatformServices.Desktop.csproj.

Locally, I included the 'net46' in the target frameworks for those projects (next to the 'net45') and it just works. I'm thinking it might be the version of the SDK I'm using for building, but not sure.

Any thought?

Mayank Bansal (mayankbansal018) · 2018-11-14T07:18:58Z

Carlos Parra (@parrainc) I'm not sure what is causing this issue. I'll however will do try to take a look at it over the weekend.

Mayank Bansal (mayankbansal018) · 2018-11-18T13:54:50Z

Carlos Parra (@parrainc) I just tried building this locally, & it worked fine. Were you able to build it locally or are you facing build issues locally as well?

Mayank Bansal (mayankbansal018) · 2018-11-18T13:55:07Z

dotnet bot (@dotnet-bot) test Windows / Debug Build please

Carlos Parra (parrainc) · 2018-11-18T23:31:14Z

Mayank Bansal (@mayankbansal018) For me it builds locally in VS. In CLI throws me the error I pointed out above.

Something i'm curious is the reason why is failing here. Check the details and looks like a type exists in two assemblies that is calling it.

Mayank Bansal (mayankbansal018) · 2018-11-19T05:24:10Z

Carlos Parra (@parrainc) I'll try to login to the CI machines, & see what is causing this.

Mayank Bansal (mayankbansal018) and others added 8 commits April 26, 2018 21:05

Make TestFx repo CPS Based

f529b75

First Iteration

Build Fix

0e44548

build fix

6129834

Build error fix

0fa46db

Test FIx

d218775

Fix Smoke Tests

74e1fc1

Fixing File Version Generation

30964b4

Run Netcore Tests

fb9034d

Mayank Bansal (mayankbansal018) closed this Apr 27, 2018

Mayank Bansal (mayankbansal018) reopened this Apr 27, 2018

Mayank Bansal (mayankbansal018) requested a review from Jayarani garg (jayaranigarg) April 27, 2018 14:28

Mayank Bansal (mayankbansal018) self-assigned this Apr 30, 2018

Jayarani garg (jayaranigarg) reviewed May 11, 2018

View reviewed changes

Mayank Bansal (mayankbansal018) mentioned this pull request Aug 3, 2018

Stack overflow in ReflectHelper #467

Closed

Carlos Parra (parrainc) mentioned this pull request Aug 30, 2018

Abstract class TestContext has different definitions for IDictionary properties between netframework and netstandard #474

Closed

Carlos Parra (parrainc) added 4 commits October 29, 2018 10:00

Merge branch 'master' of https://github.com/Microsoft/testfx into mak…

f25a4da

…eTestFxCPS

Fixed Build issues with assemblies reference

798bb31

Merge branch 'master' of https://github.com/Microsoft/testfx into mak…

14700de

…eTestFxCPS

Adding condition package reference on PlatformServices.Interface proj

6fea4a2

Merge branch 'master' of https://github.com/Microsoft/testfx into mak…

386ca8d

…eTestFxCPS

Carlos Parra (parrainc) mentioned this pull request Dec 4, 2018

No 'AddResultFile' implementation in TestContext on .NET Core 2.0 test project #394

Closed

Max (PossiblyMax) mentioned this pull request Mar 15, 2019

Add explicit support for netstandard 2.0 to reduce the dependencies for 2.x+ consumers #582

Closed

Carlos Parra (parrainc) mentioned this pull request Apr 25, 2019

Make TestFx repo CPS based #606

Closed

4 tasks

Sarabjot Singh (singhsarab) closed this Dec 13, 2019

Conversation

Mayank Bansal (mayankbansal018) commented Apr 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mayank Bansal (mayankbansal018) commented Apr 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Sarabjot Singh (singhsarab) commented Aug 1, 2018

Uh oh!

Jayarani garg (jayaranigarg) commented Aug 30, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Aug 30, 2018

Uh oh!

Carlos Parra (parrainc) commented Oct 17, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Oct 29, 2018

Uh oh!

Carlos Parra (parrainc) commented Oct 29, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Oct 29, 2018

Uh oh!

Carlos Parra (parrainc) commented Nov 7, 2018

Uh oh!

Morten Nielsen (dotMorten) commented Nov 7, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Nov 11, 2018

Uh oh!

Carlos Parra (parrainc) commented Nov 13, 2018

Uh oh!

Carlos Parra (parrainc) commented Nov 13, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Nov 14, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Nov 18, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Nov 18, 2018

Uh oh!

Carlos Parra (parrainc) commented Nov 18, 2018

Uh oh!

Mayank Bansal (mayankbansal018) commented Nov 19, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Mayank Bansal (mayankbansal018) commented Apr 26, 2018 •

edited

Loading