Skip to content

Fix nsg creation issues #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Umachandar Jayachandran (uc-msft) merged 2 commits into from
May 22, 2019
Merged

Fix nsg creation issues #566

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b27b484
Rules should be single rule for multiple ports.
mike-barry-gmo May 20, 2019
78ff1d0
When no NSG exists, all rules have failed
mike-barry-gmo May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 10 additions & 49 deletions samples/manage/azure-sql-db-managed-instance/prepare-subnet/prepareSubnet.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,39 +182,11 @@ function DefineSecurityRules{
$securityRules = New-Object "$NScollections.List``1[$NSnetworkModels.PSSecurityRule]"
#begin NSG inbound rules
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-inbound-9000 `
-Description "Allow inbound TCP traffic on port 9000" `
-Name prepare-allow-management-inbound `
-Description "Allow inbound TCP traffic on ports 9000,9003,1438,1440,1452" `
-Direction Inbound -Priority 110 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 9000
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-inbound-9003 `
-Description "Allow inbound TCP traffic on port 9003" `
-Direction Inbound -Priority 120 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 9003
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-inbound-1438 `
-Description "Allow inbound TCP traffic on port 1438" `
-Direction Inbound -Priority 130 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 1438
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-inbound-1440 `
-Description "Allow inbound TCP traffic on port 1440" `
-Direction Inbound -Priority 140 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 1440
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-inbound-1452 `
-Description "Allow inbound TCP traffic on port 1452" `
-Direction Inbound -Priority 150 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 1452
-SourcePortRange * -DestinationPortRange @(9000, 9003, 1438, 1440, 1452)
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-mi_subnet-inbound `
Expand All @@ -225,33 +197,19 @@ function DefineSecurityRules{
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-health_probe-inbound `
-Description "Allow healt probe inbound" `
-Description "Allow health probe inbound" `
-Direction Inbound -Priority 170 -Access Allow -Protocol * `
-SourceAddressPrefix AzureLoadBalancer -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange *
$securityRules.Add($rule)
#end NSG inbound rules
#begin NSG outbound rules
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-outbound-80 `
-Description "Allow outbound TCP traffic on port 80" `
-Name prepare-allow-management-outbound `
-Description "Allow outbound TCP traffic on port 80,443,12000" `
-Direction Outbound -Priority 110 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 80
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-outbound-443 `
-Description "Allow outbound TCP traffic on port 443" `
-Direction Outbound -Priority 120 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 443
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-management-outbound-12000 `
-Description "Allow outbound TCP traffic on port 12000" `
-Direction Outbound -Priority 130 -Access Allow -Protocol Tcp `
-SourceAddressPrefix * -DestinationAddressPrefix * `
-SourcePortRange * -DestinationPortRange 12000
-SourcePortRange * -DestinationPortRange @(80, 443, 12000)
$securityRules.Add($rule)
$rule = New-AzureRmNetworkSecurityRuleConfig `
-Name prepare-allow-mi_subnet-outbound `
Expand Down Expand Up @@ -502,6 +460,9 @@ function VerifyNSG {
}
$result['success'] = $result['failedSecurityRules'].Count -eq 0
}
Else {
$result['failedSecurityRules'] = DefineSecurityRules
}
If($true -eq $result['success'])
{
Write-Host "Passed Validation - Network security group." -ForegroundColor Green
Expand Down