Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .github/workflows/check-worker-versions.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,22 @@ const { parse }: { parse: (source: string) => unknown } =

interface Step {
id?: string;
name?: string;
run?: string;
env?: Record<string, string>;
}

interface WorkerVersionWorkflow {
permissions: Record<string, string>;
jobs: Record<string, { steps: Step[] }>;
}

const workflow = parse(readFileSync(".github/workflows/check-worker-versions.yml", "utf8")) as WorkerVersionWorkflow;
const setupStep = workflow.jobs["setup-matrix"].steps.find((candidate) => candidate.id === "set")!;
const createIssueStep = workflow.jobs["check-versions"].steps.find((candidate) => candidate.id === "create_issue")!;
const dispatchUpgradeStep = workflow.jobs["check-versions"].steps.find(
(candidate) => candidate.name === "Dispatch worker version upgrade",
)!;
const expectedWorkers = [
{ worker: "coder-acp-copilot", checker: "version-checker-acp-copilot" },
{ worker: "coder-acp-claude-code", checker: "version-checker-claude-code" },
Expand Down Expand Up @@ -68,4 +74,15 @@ describe("Check Worker Versions workflow", () => {
it.each(expectedWorkers)("selects only $worker when requested", ({ worker, checker }) => {
expect(selectedWorkers(worker)).toEqual([{ worker, checker }]);
});

it("dispatches the upgrade workflow explicitly after creating an issue", () => {
expect(workflow.permissions.actions).toBe("write");
expect(createIssueStep.env?.GH_TOKEN).toBe("${{ secrets.GITHUB_TOKEN }}");
expect(createIssueStep.run).toContain('echo "issue_number=$ISSUE_NUMBER" >> $GITHUB_OUTPUT');
expect(dispatchUpgradeStep.env?.GH_TOKEN).toBe("${{ secrets.GITHUB_TOKEN }}");
expect(dispatchUpgradeStep.run).toContain("gh workflow run worker-version-upgrade.lock.yml");
expect(dispatchUpgradeStep.run).toContain('-f issue_number="${{ steps.create_issue.outputs.issue_number }}"');
expect(dispatchUpgradeStep.run).toContain('--arg actor "${{ github.actor }}"');
expect(dispatchUpgradeStep.run).toContain('--arg command_name "worker-version-upgrade"');
});
});
28 changes: 28 additions & 0 deletions .github/workflows/check-worker-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ on:
- coder-acp-claude-code

permissions:
actions: write
contents: read
issues: write

Expand Down Expand Up @@ -207,7 +208,34 @@ jobs:
--title "${{ steps.check.outputs.title }}" \
--body-file /tmp/issue-body.md \
--label "type: worker-update")
ISSUE_NUMBER="${ISSUE_URL##*/}"
echo "issue_url=$ISSUE_URL" >> $GITHUB_OUTPUT
echo "issue_number=$ISSUE_NUMBER" >> $GITHUB_OUTPUT

- name: Dispatch worker version upgrade
if: steps.create_issue.outputs.issue_number != ''
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
AW_CONTEXT=$(jq -Rs \
--arg actor "${{ github.actor }}" \
--arg command_name "worker-version-upgrade" \
--arg issue_number "${{ steps.create_issue.outputs.issue_number }}" \
'{
actor: $actor,
command_name: $command_name,
item_type: "issue",
item_number: ($issue_number | tonumber),
issue_number: $issue_number,
issue_body: .
}' \
/tmp/issue-body.md)

# workflow_dispatch is allowed to create a downstream run with GITHUB_TOKEN.
gh workflow run worker-version-upgrade.lock.yml \
--ref "${{ github.ref_name }}" \
-f issue_number="${{ steps.create_issue.outputs.issue_number }}" \
-f aw_context="$AW_CONTEXT"

- name: Close superseded issue
if: steps.existing.outputs.exists == 'true' && steps.existing.outputs.same_version == 'false' && steps.create_issue.outputs.issue_url != ''
Expand Down
Loading
Loading