Fixes AllowAutoRedirect should be false #9310 - #9353
Fixes AllowAutoRedirect should be false #9310#9353Graham Lyus (grahamlyus) wants to merge 1 commit into
Conversation
|
Julio César Rocha (@JunielKatarn) do you have insight into the correct behavior here? |
Based on react-native's sources, neither iOS, Android or Office's closed-source HTTP module seem to explicitly declare allowing/disabling redirects. Graham Lyus (@grahamlyus) if your statement in #9310 holds true, this change seems correct in principle. Ideally, this change should:
|
|
Julio César Rocha (@JunielKatarn) as I mentioned in #9310, the auto redirect isn't even handled as it's expecting the user to confirm the redirect somehow - error: 0x80072F88 - The HTTP redirect request must be confirmed by the user. I'm not sure how that could fixed or how to make the AllowAutoRedirect configurable, I'm afraid this is the first Windows code I've seen in 15 years! :) |
|
Julio César Rocha (@JunielKatarn) Can you take a look fresh look at this PR? Is it possible help bridge those last requirements on the bug fix (configuration and test coverage)? |
|
Addressed by #10534. |
Description
Fixes #9310
Type of Change
Why
AllowAutoRedirect is true by default, and this causes network requests to fail without much information other than "Unhandled exception during request" . Using the debugger, I found this was due to 0x80072F88 - The HTTP redirect request must be confirmed by the user.
react-native on iOS/Android/macOS does not automatically follow redirects.
Resolves #9310
What
Uses HttpBaseProtocolFilter to disable auto redirects.
Microsoft Reviewers: Open in CodeFlow