Fix crash in Islands when opening Flyout without a target - #8300
Merged
Nick Gerleman (NickGerleman) merged 3 commits intoOct 8, 2021
Merged
Conversation
ghost
added
Alexander Sklar (asklar)
approved these changes
Jul 21, 2021
Member
|
Liron Yahdav (@lyahdav) we have a thread with you guys about whether we'd use the root tag from the native ui manager, but I'm not sure if this particular PR should wait until we have a resolution to that discussion. Let me know if this is ready to merge from your perspective. |
Contributor
Author
|
It can wait until we have resolution there since it could affect this change too. Should I close it for now then? |
Contributor
|
FYI - this change is superseded by #8327 |
| // // XamlRoot added in 19H1 | ||
| if (Is19H1OrHigher()) { | ||
| if (auto xamlRoot = React::XamlUIService::GetXamlRoot(GetViewManager()->GetReactContext().Properties())) { | ||
| m_targetElement = xamlRoot.Content().try_as<xaml::FrameworkElement>(); |
Contributor
There was a problem hiding this comment.
I think we closed this PR too eagerly. I solved a slightly different issue. We still need to set the target element from the XamlRoot for XAML Islands. Liron Yahdav (@lyahdav) - could you re-open this one?
Chris Glein (chrisglein)
approved these changes
Sep 24, 2021
Co-authored-by: Chris Glein <26607885+chrisglein@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6714.
Before:
before.mov
After:
after.mov
Microsoft Reviewers: Open in CodeFlow