[0.68] Fix RuntimeOptions for RNW Desktop (#10016) - #10032
Merged
Vladimir Morozov (vmoroz) merged 1 commit intoMay 28, 2022
Merged
[0.68] Fix RuntimeOptions for RNW Desktop (#10016)#10032Vladimir Morozov (vmoroz) merged 1 commit into
Vladimir Morozov (vmoroz) merged 1 commit into
Conversation
Vladimir Morozov (vmoroz)
requested review from
a team,
Julio César Rocha (JunielKatarn) and
tudorms
May 27, 2022 23:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick PR #10016. Original PR description:
Description
Fix new
RuntimeOptions.hAPI declarations added in PR #9983.Type of Change
Why
This PR fixes API issues introduced by PR #9983.
The
RuntimeOptions.hcode there has the following issues:extern "C"for the exported functions that causes linker error when the code is used.MicrosoftReactGetRuntimeOptionStringfunction misses the__cdeclcalling conventions.constfor the results returned by value.What
This PR fixes the issues mentioned above.
Testing
The issue was identified when I tried to use the RNW Desktop NuGet package version 0.66.19 in Office.
After these changes and additional changes to Office code related to the
IWebSocketResourcenamespace changes, I could compile and run the Office code.Microsoft Reviewers: Open in CodeFlow