The JSConverter is added for value conversion in JSValue.cpp. The JSValueReader and JSValueWriter also need to do similar conversions, but currently they use different algorithms. It would beneficial that all conversions are done uniformly between these classes. E.g. there is special logic how to convert NaN to a string.
The change will require to move the JSConverter implementation into its own header file JSConverter.h and change JSValue, JSValueReader, and JSValueWriter to use this new class.
The
JSConverteris added for value conversion inJSValue.cpp. TheJSValueReaderandJSValueWriteralso need to do similar conversions, but currently they use different algorithms. It would beneficial that all conversions are done uniformly between these classes. E.g. there is special logic how to convertNaNto a string.The change will require to move the
JSConverterimplementation into its own header fileJSConverter.hand changeJSValue,JSValueReader, andJSValueWriterto use this new class.