fix(ios): workaround for Alert not showing - #1097
Merged
Merged
Conversation
Tommy Nguyen (tido64)
requested review from
Adam Foxman (afoxman),
Lorenzo Sciandra (kelset) and
Tom Underhill (tom-un)
September 7, 2022 12:26
34 tasks
Tom Underhill (tom-un)
approved these changes
Sep 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alertdoes not display in our app. It looks like it is broken because core creates a separateUIWindowto present the alert from. In theUISceneworld, this window is no longer attached by default, you have to explicitly attach it to a scene. I have an upstream PR to fix this, but we still need to swizzle things while we wait for that fix to land and get published.Platforms affected
Test plan
See the repro steps in react/react-native#34562.