This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Improvements to Microsoft.Quantum.Random namespace - #328
Merged
Conversation
…-runtime into cgranade/random
Mathias Soeken (msoeken)
left a comment
Mathias Soeken (msoeken)
left a comment
Member
There was a problem hiding this comment.
Great to see these improvements to the M.Q.Random namespace, thanks. Left some comments for now
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
…-runtime into cgranade/random
Mathias Soeken (msoeken)
left a comment
Mathias Soeken (msoeken)
left a comment
Member
There was a problem hiding this comment.
Some more comments on the most recent changes. These are very nice tests!
…trinsicTests.csproj Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
…ndom/Tests.qs Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
…ndom/Tests.qs Co-authored-by: Mathias Soeken <mathias.soeken@outlook.com>
Cassandra Granade (cgranade)
changed the title
Cassandra Granade (cgranade)
marked this pull request as ready for review
August 18, 2020 16:33
Contributor
Author
Thank you for your feedback, and for your kind words! |
Mathias Soeken (msoeken)
approved these changes
Aug 18, 2020
Mathias Soeken (msoeken)
left a comment
Mathias Soeken (msoeken)
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the proposal in microsoft/QuantumLibraries#304 as part of the QSharpCore project for dependency ordering, and makes changes to simulators needed to adapt to the new API. As a part of that work, this PR also consolidates random number generation logic into
SimulatorBase, so that random seeds can be set in a more uniform fashion.This PR is open for early feedback only.Work deferred to future PR: