This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Add new MaybeDisplayDiagnostic method to SimBase. - #283
Merged
Conversation
Bettina Heim (bettinaheim)
approved these changes
Jun 25, 2020
Aniket Sudeep Dalvi (AniketDalvi)
pushed a commit
that referenced
this pull request
Jul 1, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new event to
SimulatorBaseto allow passing displayable diagnostic data from simulators through to host programs. By intention, data passed to this event is intended to be ignorable, allowing host programs to respond to types of diagnostic data that they recognize.+Ryan Shaffer (@rmshaffer): My thought is to add a hook to this event to the
%simulatemagic as well, allowing simulators to more directly inject displayable data into IQ# as well.