This repository was archived by the owner on Jan 12, 2024. It is now read-only.
removed sync over async in LazyAsync - #238
Merged
Bettina Heim (bettinaheim) merged 4 commits intoJun 15, 2020
Merged
Conversation
Bettina Heim (bettinaheim)
left a comment
Bettina Heim (bettinaheim)
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, César Zaragoza Cortés (@cesarzc) for a second set of eyes.
Brianna Marshall (bamarsha)
requested a review
from César Zaragoza Cortés (cesarzc)
June 8, 2020 22:42
César Zaragoza Cortés (cesarzc)
requested a review
from George Moussa (george-moussa)
June 12, 2020 21:19
George Moussa (george-moussa)
requested review from
John Azariah (johnazariah)
and removed request for
George Moussa (george-moussa)
June 12, 2020 21:29
John Azariah (johnazariah)
approved these changes
Jun 12, 2020
John Azariah (johnazariah)
left a comment
John Azariah (johnazariah)
left a comment
Member
There was a problem hiding this comment.
Yes, I agree this looks cleaner!
Thanks for this, Filip W (@filipw)!
César Zaragoza Cortés (cesarzc)
approved these changes
Jun 12, 2020
César Zaragoza Cortés (cesarzc)
left a comment
César Zaragoza Cortés (cesarzc)
left a comment
Contributor
There was a problem hiding this comment.
Looks great!
Aniket Sudeep Dalvi (AniketDalvi)
pushed a commit
that referenced
this pull request
Jul 1, 2020
Co-authored-by: bettinaheim <34236215+bettinaheim@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
LazyAsyncto not perform sync-over-async (no longer explicitly blocks).This is detrimental to performance and in places where there is synchronization context (e.g. xUnit tests or non-.NET Core apps) it can lead to deadlocks.
More about this in the great posts from S. Toub and S. Cleary