This repository was archived by the owner on Jan 12, 2024. It is now read-only.
Enable LiftLambdaExpressions by default in configuration - #1381
Merged
Conversation
Brianna Marshall (bamarsha)
marked this pull request as ready for review
March 17, 2022 23:05
Brianna Marshall (bamarsha)
requested review from
Scott Carda (ScottCarda-MS) and
Cassandra Granade (cgranade)
March 17, 2022 23:06
Cassandra Granade (cgranade)
approved these changes
Mar 17, 2022
Cassandra Granade (cgranade)
left a comment
Cassandra Granade (cgranade)
left a comment
Contributor
There was a problem hiding this comment.
Looks great! We should also make sure to add either per-repo tests to IQ#, or IQ# tests to the e2e build. Possibly both?
Scott Carda (ScottCarda-MS)
approved these changes
Mar 18, 2022
Contributor
Author
|
I'm not sure what you mean - I thought the tests in the IQ# repo already run automatically in the e2e build? So with microsoft/iqsharp#620, we should have enough test coverage, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves microsoft/iqsharp#606.