This repository was archived by the owner on Jan 29, 2026. It is now read-only.
Improve constraints for facade - #359
Merged
Mingxin Wang (mingxwa) merged 1 commit intoOct 22, 2025
Merged
Conversation
Mingxin Wang (mingxwa)
requested review from
Kenny Guo (guominrui) and
Tian L. (tian-lt)
October 21, 2025 14:04
Tian L. (tian-lt)
approved these changes
Oct 22, 2025
Han Jingzhi (HanJingzhi)
added a commit
to HanJingzhi/proxy
that referenced
this pull request
Oct 23, 2025
This reverts commit eea7350.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR aligns with the proposed changes in #358.
F::max_size > 0,F::max_sizeshall be a multiple ofF::max_alignandF::max_alignshall be a power of2.F::copyability/relocatability/destructibilityshall be exactly one of the four enumerators ofconstraint_level.basic_facade_builder::support_copy/support_relocation/support_destruction/restrict_layoutaccordingly.