Skip to content

chore: start the review bot on pull_request_target again - #44219

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
agent-review-pull-request-target
Nov 18, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
agent-review-pull-request-target

Conversation

@pavelfeldman

@pavelfeldman Pavel Feldman (pavelfeldman) commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

This puts agent-review.yml back on pull_request_target. It undoes the move to pull_request.

pull_request does not start a run when the PR has a merge conflict, so the agent-review label did nothing on such a PR. pull_request_target runs from the default branch and has no such limit. The workflow never checks out the PR.

The job still skips a PR from a fork. The bot cannot push to a fork, so no token is made and no run starts for it.

GitHub blocks pull_request_target in public repositories from December 2, 2026, unless an Actions policy of the repo allows it. The repo needs a policy that allows the event for this workflow. See Securely using pull_request_target.

@github-actions

This comment has been minimized.

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit 66e3f93 into main Nov 18, 2026
30 of 32 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the agent-review-pull-request-target branch November 18, 2026 18:48
@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 The failures are pre-existing, not caused by this PR

Hi, I'm the Playwright bot. I checked the failures in tests 1, run 44371427265.

Details

The failed run tested 06d568e0ca9d, an earlier revision of this PR. It changes only .github/workflows/agent-review.yml, not the test runner or JUnit reporter.

Pre-existing failures

  • [playwright-test] › reporter-junit.spec.ts:350 › should add file attribute relative to fileRoot, both created and merged, on Windows: line 374 expects classname to be auth/a.test.js, but receives auth\a.test.js. Both tests fail with the exact same assertion on the PR commit's parent, bfc459c18e03, in the main Windows job. This is a platform-specific test assertion error, not a flake. The assertion was added in feat(junit): add addFileAttribute and fileRoot options #44107; the reporter keeps platform separators in classname and normalizes only the new file attribute. A small test fix is expect(byDefault['classname']).toBe(path.join('auth', 'a.test.js')).

The video test passed on retry and is not an outstanding failure. The run was cancelled, so this verdict covers the reported failures, not the unfinished parts of the suite.

Checked the failures on Linux by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5237 passed, 633 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [playwright-test] › reporter-junit.spec.ts:350 › created › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22
❌ [playwright-test] › reporter-junit.spec.ts:350 › merged › should add file attribute relative to fileRoot @playwright-x64-server2025-64-core-node22

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`

23641 passed, 716 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants