Repository navigation
fix(ui-mode): show the trace viewer in a frame from its own server - #44196
Pavel Feldman (pavelfeldman) merged 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
🟢 All three failures predate this PRI'm the Playwright bot. I checked the MCP run at Failure details and evidencePre-existing flake / infra All three Chrome/Linux failures already occur on
The PR changes UI mode, trace-viewer framing, and app settings. It does not change the MCP fixtures, crash-recovery code, or Chromium backend. These failures are not introduced by this PR; the evidence does not establish whether they are intermittent or consistently broken. Checked the failures on Linux by the Playwright bot - agent run |
This comment has been minimized.
This comment has been minimized.
🟢 Both failures predate this PRI'm the Playwright bot. I checked the tests 1 run at Failure details and evidenceThe UI mode changes do not affect the JUnit reporter, test file loading, or the failing test. Pre-existing flake / infra
The test was added in #44107. The MCP failures already have a verdict in the earlier bot comment; this comment covers only Checked the failures on Linux by the Playwright bot - agent run |
4333b17 to
031afac
Compare
| // Keep SW running. | ||
| setInterval(function() { fetch('ping'); }, 10000); | ||
| } | ||
| if (window.location.protocol !== 'file:') |
There was a problem hiding this comment.
drop this check?
Test results for "tests 1"2 failed 3 flaky23639 passed, 716 skipped Merge workflow run. |
🟢 Both failures predate this PRI'm the Playwright bot. I checked the tests 1 run at Failure details and evidenceThe UI mode and trace-viewer changes do not affect the JUnit reporter, this test, or its shared fixture. Pre-existing flake / infra
The small fix remains to expect Checked the failures on Linux by the Playwright bot - agent run |
Test results for "MCP"4 failed 5236 passed, 633 skipped Merge workflow run. |
🟢 All four MCP failures predate this PRI'm the Playwright bot. I checked the MCP run at Failure details and evidenceThe PR changes UI mode, trace-viewer framing, and app settings. It does not change the MCP fixtures, action-completion logic, crash recovery, or Chromium backend used by these tests. Pre-existing flake / infra
All three crash failures have the same errors in the parent commit's Linux job, at This verdict covers the MCP run above. The Checked the failures on Linux by the Playwright bot - agent run |
dc99b6c
into
microsoft:main
Summary
traceFrame(page)helper.With
--ui-host/--ui-port, the trace viewer port is random and must be reachable from the browser too.